Skip to content

docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票(ADR-0024 / #526)#537

Merged
yusuke0610 merged 1 commit into
mainfrom
feat/pdf-import-adr
Jul 22, 2026
Merged

docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票(ADR-0024 / #526)#537
yusuke0610 merged 1 commit into
mainfrom
feat/pdf-import-adr

Conversation

@yusuke0610

Copy link
Copy Markdown
Owner

概要

手持ち PDF 経歴書のフォーム流し込み機能(#517 のコールドスタート問題解消)の設計判断を ADR-0024 として起票する。PR 1本目 / ADR のみ#527 backend・#528 web が後続)。

決定内容

ADR-0004 で導入し ADR-0008 で撤去した「PDF 経歴書の AI 抽出」を、ADR-0010 の不変条件(DB 非更新・明示的エラー契約)と ADR-0023 の Haiku 固定の上で再導入する。旧設計の敗因(generate() が失敗時に空文字を返し UI にエラーが届かなかった)を契約で構造的に封じる。

代替案(却下理由)

  • 非同期化(ADR-0020): 抽出+1コールは同期 60s 内。タスク基盤は過剰
  • pdfplumber / PyMuPDF: 依存過多 / AGPL・native 依存
  • v1 で OCR: コスト・失敗モードが別物。将来判断

テスト

make lint-adr-index green(ADR ファイル ↔ 索引・系統図の drift なし)。docs のみの変更。

🤖 Generated with Claude Code

ADR-0004 で導入し ADR-0008 で撤去した「PDF 経歴書の AI 抽出」を、ADR-0010 の
不変条件(DB 非更新・明示的エラー契約)と ADR-0023 の Haiku 固定の上で再導入する
設計判断を記録。空フォーム離脱の解消(コールドスタート問題)が動機。

決定:
- v1 はテキスト埋め込み PDF のみ(スキャンは判定して日本語エラー)
- 抽出は pypdf(純 Python・MIT・native 依存なし)を == 固定で追加
- 同期エンドポイント POST /agent/resume-import/pdf(multipart)→ Resume 互換
  payload 即返却・DB 非更新でフォーム注入機構(#524)へ渡す
- エラー契約で旧敗因(空文字握りつぶし)を構造的に封じる
- レート制限(#521)・アップロード検証(magic bytes / サイズ上限)を明記

docs/adr/README.md 索引・系統図も同一 PR で更新(make lint-adr-index green)。

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@yusuke0610, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 13 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 16e16fec-a85f-4792-94cc-a7f89ac15e47

📥 Commits

Reviewing files that changed from the base of the PR and between 1749be5 and abae783.

📒 Files selected for processing (2)
  • docs/adr/0024-pdf-resume-import.md
  • docs/adr/README.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/pdf-import-adr

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jul 22, 2026
@yusuke0610
yusuke0610 merged commit 1120e8d into main Jul 22, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant